Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdf): Add ability to set a module as private when contributing #5614

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Mar 6, 2025

This means that when we won't show this module in module listings and it will be available for you on all workspaces you log into

This is feature flagged and will not yet be available to users

@github-actions github-actions bot added A-sdf Area: Primary backend API service [Rust] A-dal A-web labels Mar 6, 2025
Copy link

github-actions bot commented Mar 6, 2025

Dependency Review

✅ No vulnerabilities or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@stack72 stack72 force-pushed the private-scoped-modules branch 3 times, most recently from 19f4c64 to 7732982 Compare March 6, 2025 18:27

// TO-DO: Paul
// I will refactor this + insert together - this is to temporarily get something working
async fn insert_private_module(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have done this on purpose for now - I am testing the viability of this and don't want to break any of the existing routes rigth now - I will refactor this + insert into a single function

@stack72 stack72 force-pushed the private-scoped-modules branch from 7732982 to 53e10f5 Compare March 6, 2025 18:35
@stack72
Copy link
Contributor Author

stack72 commented Mar 6, 2025

/try

Copy link

github-actions bot commented Mar 6, 2025

Okay, starting a try! I'll update this comment once it's running...\n
🚀 Try running here! 🚀

@stack72 stack72 force-pushed the private-scoped-modules branch from 53e10f5 to caecab5 Compare March 6, 2025 19:35
@stack72 stack72 force-pushed the private-scoped-modules branch from caecab5 to bf2857b Compare March 6, 2025 21:48
@stack72 stack72 force-pushed the private-scoped-modules branch 2 times, most recently from 56f0f88 to 41e8928 Compare March 7, 2025 23:20
@stack72
Copy link
Contributor Author

stack72 commented Mar 8, 2025

/try

Copy link

github-actions bot commented Mar 8, 2025

Okay, starting a try! I'll update this comment once it's running...\n
🚀 Try running here! 🚀

@stack72
Copy link
Contributor Author

stack72 commented Mar 8, 2025

/try

Copy link

github-actions bot commented Mar 8, 2025

Okay, starting a try! I'll update this comment once it's running...\n
🚀 Try running here! 🚀

This means that when we won't show this module in module listings and it will be available for you on all workspaces you log into
@stack72 stack72 force-pushed the private-scoped-modules branch from 41e8928 to 4946188 Compare March 10, 2025 15:06
v-if="isPrivateModule && featureFlagsStore.PRIVATE_SCOPED_MODULES"
>
<p>
By clicking the 'Contribute to System Initiative' button, you confirm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe this should say 'Publish' or something when it's private, vs. keeping the 'contribute' verbiage?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something we can think about after when we get eyes on it in tools prod as it's feature flagged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dal A-sdf Area: Primary backend API service [Rust] A-web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants